hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16178) corr/covar_samp UDAF standard compliance
Date Mon, 20 Mar 2017 16:40:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933004#comment-15933004
] 

Hive QA commented on HIVE-16178:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12859183/HIVE-16178.1.patch

{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10494 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[comments] (batchId=35)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udaf_corr] (batchId=73)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udaf_covar_samp] (batchId=6)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_rp_windowing_2] (batchId=144)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[windowing] (batchId=150)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[windowing] (batchId=118)
org.apache.hadoop.hive.ql.udf.generic.TestGenericUDAFCorrelation.testCorr (batchId=245)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4246/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4246/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4246/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12859183 - PreCommit-HIVE-Build

> corr/covar_samp UDAF standard compliance
> ----------------------------------------
>
>                 Key: HIVE-16178
>                 URL: https://issues.apache.org/jira/browse/HIVE-16178
>             Project: Hive
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Minor
>         Attachments: HIVE-16178.1.patch
>
>
> h3. corr
> the standard defines corner cases when it should return null - but the current result
is NaN.
> If N * SUMX2 equals SUMX * SUMX , then the result is the null value.
> and
> If N * SUMY2 equals SUMY * SUMY , then the result is the null value.
> h3. covar_samp
> returns 0 instead 1
> `If N is 1 (one), then the result is the null value.`
> h3. check (x,y) vs (y,x) args in docs
> the standard uses (y,x) order; and some of the function names are also contain X and
Y...so the order does matter..currently at least corr uses (x,y) order which is okay - because
its symmetric; but it would be great to have the same order everywhere (check others)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message