hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16174) Update MetricsConstant.WAITING_COMPILE_OPS metric when we aquire lock failed in Driver
Date Fri, 10 Mar 2017 12:19:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904981#comment-15904981
] 

Hive QA commented on HIVE-16174:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12857297/HIVE-16174.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10336 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join_without_localtask] (batchId=96)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_sortmerge_join_3] (batchId=96)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[date_join1] (batchId=96)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby6_noskew] (batchId=96)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapjoin_test_outer] (batchId=96)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[merge2] (batchId=96)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[smb_mapjoin_11] (batchId=96)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_9] (batchId=96)
org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery (batchId=219)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4066/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4066/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4066/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12857297 - PreCommit-HIVE-Build

> Update MetricsConstant.WAITING_COMPILE_OPS metric when we aquire lock failed in Driver
> --------------------------------------------------------------------------------------
>
>                 Key: HIVE-16174
>                 URL: https://issues.apache.org/jira/browse/HIVE-16174
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Planning
>    Affects Versions: 2.2.0
>            Reporter: yunfei liu
>            Assignee: yunfei liu
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: HIVE-16174.1.patch
>
>
> In Driver#compileInternal method (as the code snippet below ), we need to update  MetricsConstant.WAITING_COMPILE_OPS
metric correctly before return if lock can not be acquired.
> {code}
>     Metrics metrics = MetricsFactory.getInstance();
>     if (metrics != null) {
>       metrics.incrementCounter(MetricsConstant.WAITING_COMPILE_OPS, 1);
>     }
>     final ReentrantLock compileLock = tryAcquireCompileLock(isParallelEnabled,
>       command);
>     if (compileLock == null) {
>       return ErrorMsg.COMPILE_LOCK_TIMED_OUT.getErrorCode();
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message