hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "yunfei liu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-16174) Update MetricsConstant.WAITING_COMPILE_OPS metric when we aquire lock failed in Driver
Date Fri, 10 Mar 2017 09:42:04 GMT

     [ https://issues.apache.org/jira/browse/HIVE-16174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

yunfei liu updated HIVE-16174:
------------------------------
    Attachment: HIVE-16174.1.patch

> Update MetricsConstant.WAITING_COMPILE_OPS metric when we aquire lock failed in Driver
> --------------------------------------------------------------------------------------
>
>                 Key: HIVE-16174
>                 URL: https://issues.apache.org/jira/browse/HIVE-16174
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Planning
>    Affects Versions: 2.2.0
>            Reporter: yunfei liu
>            Assignee: yunfei liu
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: HIVE-16174.1.patch
>
>
> In Driver#compileInternal method (as the code snippet below ), we need to update  MetricsConstant.WAITING_COMPILE_OPS
metric correctly before return if lock can not be acquired.
> {code}
>     Metrics metrics = MetricsFactory.getInstance();
>     if (metrics != null) {
>       metrics.incrementCounter(MetricsConstant.WAITING_COMPILE_OPS, 1);
>     }
>     final ReentrantLock compileLock = tryAcquireCompileLock(isParallelEnabled,
>       command);
>     if (compileLock == null) {
>       return ErrorMsg.COMPILE_LOCK_TIMED_OUT.getErrorCode();
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message