hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesus Camacho Rodriguez (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-16122) NPE Hive Druid split introduced by HIVE-15928
Date Tue, 07 Mar 2017 18:07:38 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899857#comment-15899857
] 

Jesus Camacho Rodriguez edited comment on HIVE-16122 at 3/7/17 6:07 PM:
------------------------------------------------------------------------

The new code in read/write looks good.

However, about this:
{code:java}
public String[] getLocations() throws IOException {
  return hosts == null ? new String[0] : hosts;
}
{code}
We should not hit {{hosts == null}} anymore, right? I am afraid something like this will mask
possible errors.


was (Author: jcamachorodriguez):
The new code in read/write looks good.

However, about this:
{code:java}
public String[] getLocations() throws IOException {
  return hosts == null ? new String[0] : hosts;
}
{code}
We should not hit hosts == null anymore, right? I am afraid something like this will mask
possible errors.

> NPE Hive Druid split introduced by HIVE-15928
> ---------------------------------------------
>
>                 Key: HIVE-16122
>                 URL: https://issues.apache.org/jira/browse/HIVE-16122
>             Project: Hive
>          Issue Type: Bug
>          Components: Druid integration
>            Reporter: slim bouguerra
>         Attachments: HIVE-16112.2.patch, HIVE-16112.3.patch, HIVE-16122.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message