hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16104) LLAP: preemption may be too aggressive if the pre-empted task doesn't die immediately
Date Wed, 08 Mar 2017 02:02:37 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900571#comment-15900571
] 

Sergey Shelukhin commented on HIVE-16104:
-----------------------------------------

Some things that look like refactoring are not actually refactoring. The lock in trySchedule
is unnecessary so I removed it and renamed the method; preemption was surrounded by a loop
because previously, if the first task in queue was finishable it would bail without preempting
anything even if there are more tasks.
I can merge updateQueueMetric back into being copy-pasted in 3 places... also one if was refactored
because it has lots of repetitive code.

> LLAP: preemption may be too aggressive if the pre-empted task doesn't die immediately
> -------------------------------------------------------------------------------------
>
>                 Key: HIVE-16104
>                 URL: https://issues.apache.org/jira/browse/HIVE-16104
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-16104.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message