hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16060) GenericUDTFJSONTuple's json cache could overgrow beyond its limit
Date Wed, 01 Mar 2017 00:53:45 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889233#comment-15889233
] 

Hive QA commented on HIVE-16060:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12855249/HIVE-16060.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10297 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_table]
(batchId=147)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=223)
org.apache.hive.beeline.TestBeeLineWithArgs.testQueryProgressParallel (batchId=211)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3852/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3852/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3852/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12855249 - PreCommit-HIVE-Build

> GenericUDTFJSONTuple's json cache could overgrow beyond its limit
> -----------------------------------------------------------------
>
>                 Key: HIVE-16060
>                 URL: https://issues.apache.org/jira/browse/HIVE-16060
>             Project: Hive
>          Issue Type: Bug
>          Components: UDF
>            Reporter: Chao Sun
>            Assignee: Chao Sun
>         Attachments: HIVE-16060.1.patch, image.png
>
>
> At the moment the [cache object|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFJSONTuple.java#L96]
used in {{GenericUDTFJSONTuple}} is a static linked hashmap that is not thread-safe. In the
case of HoS it may be accessed concurrently and has race conditions. In particular, its size
may overgrow even though the limit is 32. This can be observed from the attached image.
> An easy way to fix it is to make it non-static.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message