hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "anishek (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16007) When the query does not complie the LogRunnable never stops
Date Thu, 02 Mar 2017 11:35:45 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892104#comment-15892104
] 

anishek commented on HIVE-16007:
--------------------------------

[~pvary] showWarnings seems to indicate warnings for connection problems.  parse failures
does not relate to connection problems and hence the change in patch to make *isLogBeingGenerated
= false;* is good. 

how ever i think we should from method
{code}
public List<String> getQueryLog(boolean incremental, int fetchSize)
      throws SQLException, ClosedOrCancelledStatementException
{code}

remove the code block
{code}
        if (isExecuteStatementFailed) {
          throw new SQLException("Method getQueryLog() failed. Because the stmtHandle in "
+
              "HiveStatement is null and the statement execution might fail.");
        }
{code}

[~thejas] what do you think ?

> When the query does not complie the LogRunnable never stops
> -----------------------------------------------------------
>
>                 Key: HIVE-16007
>                 URL: https://issues.apache.org/jira/browse/HIVE-16007
>             Project: Hive
>          Issue Type: Bug
>          Components: Beeline
>    Affects Versions: 2.2.0
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>         Attachments: HIVE-16007.2.patch, HIVE-16007.3.patch, HIVE-16007.patch
>
>
> When issuing a sql command which does not compile then the LogRunnable thread is never
closed.
> The issue can be easily detected when running beeline with showWarnings=true.
> {code}
> $ ./beeline -u "jdbc:hive2://localhost:10000 pvary pvary" --showWarnings=true
> [..]
> Connecting to jdbc:hive2://localhost:10000
> Connected to: Apache Hive (version 2.2.0-SNAPSHOT)
> Driver: Hive JDBC (version 2.2.0-SNAPSHOT)
> Transaction isolation: TRANSACTION_REPEATABLE_READ
> Beeline version 2.2.0-SNAPSHOT by Apache Hive
> 0: jdbc:hive2://localhost:10000> selekt;
> Warning: java.sql.SQLException: Method getQueryLog() failed. Because the stmtHandle in
HiveStatement is null and the statement execution might fail. (state=,code=0)
> [..]
> Warning: java.sql.SQLException: Can't getQueryLog after statement has been closed (state=,code=0)
> [..]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message