hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pengcheng Xiong (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-15616) Improve contents of qfile test output
Date Tue, 14 Mar 2017 23:35:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925244#comment-15925244
] 

Pengcheng Xiong edited comment on HIVE-15616 at 3/14/17 11:34 PM:
------------------------------------------------------------------

I had a discussion with [~ashutoshc]. Previously, if we set "-Dtest.output.overwrite=true",
we should see the test pass and the golden file be overwritten. Now, what i saw is 
{code}
<   Stage: Stage-8
<     Column Stats Work
<       Column Stats Desc:
<           Columns: key, value
<           Col
Output was too long and had to be truncated...

Tests run: 5, Failures: 5, Errors: 0, Skipped: 0
{code}

This changes the original behavior. What we are expecting is that: if we set "-Dtest.output.overwrite=true",
it is OK to print the diff information as added by this patch, but please pass the test if
the failure is just due to golden file change. This patch is going to be reverted. Could u
please address the problem and resubmit the patch? Thanks.


was (Author: pxiong):
I had a discussion with [~ashutoshc]. Previously, if we set "-Dtest.output.overwrite=true",
we should see the test pass and the golden file be overwritten. Now, what i saw is 
{code}
<   Stage: Stage-8
<     Column Stats Work
<       Column Stats Desc:
<           Columns: key, value
<           Col
Output was too long and had to be truncated...

Tests run: 5, Failures: 5, Errors: 0, Skipped: 0
{code}

This changes the original behavior. What we are expecting is that: if we set "-Dtest.output.overwrite=true",
it is OK to print the diff information as added by this patch, but please pass the test. This
patch is going to be reverted. Could u please address the problem and resubmit the patch?
Thanks.

> Improve contents of qfile test output
> -------------------------------------
>
>                 Key: HIVE-15616
>                 URL: https://issues.apache.org/jira/browse/HIVE-15616
>             Project: Hive
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 2.1.1
>            Reporter: Barna Zsombor Klara
>            Assignee: Barna Zsombor Klara
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: HIVE-15616.1.patch, HIVE-15616.2.patch, HIVE-15616.3.patch, HIVE-15616.4.patch,
HIVE-15616.patch
>
>
> The current output of the failed qtests has a less than ideal signal to noise ratio.
> We have duplicated stack traces and messages between the error message/stack trace/error
out.
> For diff errors the actual difference is missing from the error message and can be found
only in the standard out.
> I would like to simplify this output by removing duplications, moving relevant information
to the top.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message