hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-13415) Decouple Sessions from thrift binary transport
Date Tue, 28 Mar 2017 07:32:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944691#comment-15944691
] 

Lefty Leverenz commented on HIVE-13415:
---------------------------------------

This is documented now.  [~vihangk1] added a section to HiveServer2 Clients (thanks, Vihang)
and I put *hive.server2.close.session.on.disconnect* in Configuration Properties:

* [HiveServer2 Clients -- Cancelling the Query | https://cwiki.apache.org/confluence/display/Hive/HiveServer2+Clients#HiveServer2Clients-CancellingtheQuery]
* [hive.server2.close.session.on.disconnect | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.server2.close.session.on.disconnect]

Removed the TODOC2.1 label.

> Decouple Sessions from thrift binary transport
> ----------------------------------------------
>
>                 Key: HIVE-13415
>                 URL: https://issues.apache.org/jira/browse/HIVE-13415
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>    Affects Versions: 1.2.0
>            Reporter: Rajat Khandelwal
>            Assignee: Rajat Khandelwal
>             Fix For: 2.1.0
>
>         Attachments: HIVE-13415.01.patch, HIVE-13415.04.patch, HIVE-13415.05.patch
>
>
> Current behaviour is:
> * Open a thrift binary transport
> * create a session
> * close the transport
> Then the session gets closed. Consequently, all the operations running in the session
also get killed.
> Whereas, if you open an HTTP transport, and close, the enclosing sessions are not closed.

> This seems like a bad design, having transport and sessions tightly coupled. I'd like
to fix this. 
> The issue that introduced it is [HIVE-9601|https://github.com/apache/hive/commit/48bea00c48853459af64b4ca9bfdc3e821c4ed82]
Relevant discussions at [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223546&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223546],
[here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223827]
and mentioned links on those comments. 
> Another thing that seems like a slightly bad design is this line of code in ThriftBinaryCLIService:
> {noformat}
> server.setServerEventHandler(serverEventHandler);
> {noformat}
> Whereas serverEventHandler is defined by the base class, with no users except one sub-class(ThriftBinaryCLIService),
violating the separation of concerns. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message