Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 87009200C1E for ; Fri, 17 Feb 2017 20:04:46 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 85872160B57; Fri, 17 Feb 2017 19:04:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CF5FB160B46 for ; Fri, 17 Feb 2017 20:04:45 +0100 (CET) Received: (qmail 46304 invoked by uid 500); 17 Feb 2017 19:04:45 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 46295 invoked by uid 99); 17 Feb 2017 19:04:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2017 19:04:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8A4951857AE for ; Fri, 17 Feb 2017 19:04:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id A4M2olK0ctB7 for ; Fri, 17 Feb 2017 19:04:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D322F5F36C for ; Fri, 17 Feb 2017 19:04:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1F60AE0146 for ; Fri, 17 Feb 2017 19:04:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D1ACD2411B for ; Fri, 17 Feb 2017 19:04:41 +0000 (UTC) Date: Fri, 17 Feb 2017 19:04:41 +0000 (UTC) From: "Thejas M Nair (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-15969) Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 17 Feb 2017 19:04:46 -0000 [ https://issues.apache.org/jira/browse/HIVE-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15969: --------------------------------- Description: Looks like the additional failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer are related to this patch in HIVE-15877. I don't think that change was intended. {code} --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java +++ metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java @@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext envContext) throws Already hook.commitCreateTable(tbl); } success = true; - } finally { + } catch (Exception e){ + LOG.error("Got exception from createTable", e); + } + finally { if (!success && (hook != null)) { hook.rollbackCreateTable(tbl); } {code} was: Pasting comment from HIVE-15877 [~ashutoshc] [~bslim] Looks like the additional failures in the unit tests seen here are related to this patch. I will create a new jira. Is that change needed ? {code} --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java +++ metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java @@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext envContext) throws Already hook.commitCreateTable(tbl); } success = true; - } finally { + } catch (Exception e){ + LOG.error("Got exception from createTable", e); + } + finally { if (!success && (hook != null)) { hook.rollbackCreateTable(tbl); } {code} > Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer > ----------------------------------------------------------- > > Key: HIVE-15969 > URL: https://issues.apache.org/jira/browse/HIVE-15969 > Project: Hive > Issue Type: Sub-task > Affects Versions: 2.2.0 > Reporter: Thejas M Nair > > Looks like the additional failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer > are related to this patch in HIVE-15877. > I don't think that change was intended. > {code} > --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > +++ metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > @@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext envContext) throws Already > hook.commitCreateTable(tbl); > } > success = true; > - } finally { > + } catch (Exception e){ > + LOG.error("Got exception from createTable", e); > + } > + finally { > if (!success && (hook != null)) { > hook.rollbackCreateTable(tbl); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)