Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 55B82200C12 for ; Sun, 5 Feb 2017 18:42:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 54513160B48; Sun, 5 Feb 2017 17:42:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9DD96160B59 for ; Sun, 5 Feb 2017 18:42:47 +0100 (CET) Received: (qmail 43787 invoked by uid 500); 5 Feb 2017 17:42:46 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 43778 invoked by uid 99); 5 Feb 2017 17:42:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Feb 2017 17:42:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6397EC0027 for ; Sun, 5 Feb 2017 17:42:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id rDMA5243AamE for ; Sun, 5 Feb 2017 17:42:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 792485FB9F for ; Sun, 5 Feb 2017 17:42:45 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 152ACE0485 for ; Sun, 5 Feb 2017 17:42:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B95AC2528C for ; Sun, 5 Feb 2017 17:42:41 +0000 (UTC) Date: Sun, 5 Feb 2017 17:42:41 +0000 (UTC) From: "Nandakumar (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-15792) Hive should raise SemanticException when LPAD/RPAD pad character's length is 0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 05 Feb 2017 17:42:48 -0000 [ https://issues.apache.org/jira/browse/HIVE-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853284#comment-15853284 ] Nandakumar commented on HIVE-15792: ----------------------------------- Thanks [~thejas] As suggested the check is added in {{GenericUDFBasePad}}, which will now return {{null}} if the pad string is empty. Please review the patch. > Hive should raise SemanticException when LPAD/RPAD pad character's length is 0 > ------------------------------------------------------------------------------ > > Key: HIVE-15792 > URL: https://issues.apache.org/jira/browse/HIVE-15792 > Project: Hive > Issue Type: Improvement > Reporter: Zoltan Chovan > Assignee: Nandakumar > Priority: Minor > Attachments: HIVE-15792.000.patch > > > For example SELECT LPAD('A', 2, ''); will cause an infinite loop and the running query will hang without any error. > It would be great if this could be prevented by checking the pad character's length and if it's 0 then throw a SemanticException. -- This message was sent by Atlassian JIRA (v6.3.15#6346)