Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A150E200C13 for ; Mon, 6 Feb 2017 12:08:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A000A160B53; Mon, 6 Feb 2017 11:08:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E9240160B49 for ; Mon, 6 Feb 2017 12:08:46 +0100 (CET) Received: (qmail 47356 invoked by uid 500); 6 Feb 2017 11:08:46 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 47347 invoked by uid 99); 6 Feb 2017 11:08:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Feb 2017 11:08:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7DC26C12C0 for ; Mon, 6 Feb 2017 11:08:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ebLziDlJI4Pp for ; Mon, 6 Feb 2017 11:08:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 92F135F283 for ; Mon, 6 Feb 2017 11:08:44 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 588C3E042C for ; Mon, 6 Feb 2017 11:08:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B71E72528E for ; Mon, 6 Feb 2017 11:08:41 +0000 (UTC) Date: Mon, 6 Feb 2017 11:08:41 +0000 (UTC) From: "Teddy Choi (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-14450) Vectorization: StringExpr::truncate() can assume 1 byte per-char minimum MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 06 Feb 2017 11:08:47 -0000 [ https://issues.apache.org/jira/browse/HIVE-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Teddy Choi updated HIVE-14450: ------------------------------ Attachment: HIVE-14450.1.patch > Vectorization: StringExpr::truncate() can assume 1 byte per-char minimum > ------------------------------------------------------------------------ > > Key: HIVE-14450 > URL: https://issues.apache.org/jira/browse/HIVE-14450 > Project: Hive > Issue Type: Improvement > Components: Vectorization > Affects Versions: 2.2.0 > Reporter: Gopal V > Assignee: Teddy Choi > Attachments: HIVE-14450.1.patch > > > {code} > public static int truncate(byte[] bytes, int start, int length, int maxLength) { > int end = start + length; > // count characters forward > int j = start; > int charCount = 0; > while(j < end) { > // UTF-8 continuation bytes have 2 high bits equal to 0x80. > if ((bytes[j] & 0xc0) != 0x80) { > if (charCount == maxLength) { > break; > } > ++charCount; > } > j++; > } > return (j - start); > } > {code} > Should not read the bytes if the maxLength is 4096 and the input string has 256 bytes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)