Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DCC0D200C2B for ; Thu, 16 Feb 2017 05:52:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DB469160B70; Thu, 16 Feb 2017 04:52:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2F675160B5E for ; Thu, 16 Feb 2017 05:52:02 +0100 (CET) Received: (qmail 78241 invoked by uid 500); 16 Feb 2017 04:52:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 78232 invoked by uid 99); 16 Feb 2017 04:52:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Feb 2017 04:52:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E0C21C010D for ; Thu, 16 Feb 2017 04:52:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id oDg9_-b4PpQY for ; Thu, 16 Feb 2017 04:52:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B6A975F370 for ; Thu, 16 Feb 2017 04:51:59 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 853DCE0570 for ; Thu, 16 Feb 2017 04:51:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B628D24125 for ; Thu, 16 Feb 2017 04:51:41 +0000 (UTC) Date: Thu, 16 Feb 2017 04:51:41 +0000 (UTC) From: "Thejas M Nair (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-10562) Add versioning/format mechanism to NOTIFICATION_LOG entries, expand MESSAGE size MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 16 Feb 2017 04:52:03 -0000 [ https://issues.apache.org/jira/browse/HIVE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869171#comment-15869171 ] Thejas M Nair commented on HIVE-10562: -------------------------------------- [~spena] For some reason the tests for metastore schema upgrade in HIVE-9800 didn't get kicked off in this case. Any idea why ? > Add versioning/format mechanism to NOTIFICATION_LOG entries, expand MESSAGE size > -------------------------------------------------------------------------------- > > Key: HIVE-10562 > URL: https://issues.apache.org/jira/browse/HIVE-10562 > Project: Hive > Issue Type: Sub-task > Components: Import/Export > Affects Versions: 1.2.0 > Reporter: Sushanth Sowmyan > Assignee: Sushanth Sowmyan > Fix For: 2.2.0 > > Attachments: HIVE-10562.2.patch, HIVE-10562.3.patch, HIVE-10562.4.patch, HIVE-10562.5.patch, HIVE-10562.patch > > > Currently, we have a JSON encoded message being stored in the NOTIFICATION_LOG table. > If we want to be future proof, we need to allow for versioning of this message, since we might change what gets stored in the message. A prime example of what we'd want to change is as in HIVE-10393. > MessageFactory already has stubs to allow for versioning of messages, and we could expand on this further in the future. NotificationListener currently encodes the message version into the header for the JMS message it sends, which seems to be the right place for a message version (instead of being contained in the message, for eg.). > So, we should have a similar ability for DbEventListener as well, and the place this makes the most sense is to and add a version column to the NOTIFICATION_LOG table. -- This message was sent by Atlassian JIRA (v6.3.15#6346)