hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vihang Karajgaonkar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16024) MSCK Repair Requires nonstrict hive.mapred.mode
Date Thu, 23 Feb 2017 16:55:44 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880833#comment-15880833
] 

Vihang Karajgaonkar commented on HIVE-16024:
--------------------------------------------

Thanks [~zsombor.klara] for the patch. Took a quick look at the patch. Is the issue due to
{{hive.strict.checks.large.query}} instead of {{hive.mapred.mode}}? Looks like the following
code in PartitionPruner is throwing the exception which checks for a {{hive.strict.checks.large.query}}
instead of the config in description.

{noformat}
if (!hasColumnExpr(prunerExpr)) {
      // If the "strict" mode is on, we have to provide partition pruner for each table.
      String error = StrictChecks.checkNoPartitionFilter(conf);
      if (error != null) {
        throw new SemanticException(error + " No partition predicate for Alias \""
            + alias + "\" Table \"" + tab.getTableName() + "\"");
      }
    }
{noformat}

Also, Can you use {{PartitionPruner.getAllPartitions}} method instead of {{hive.getAllPartitionsOf(table)}}.
It uses some performance logging which can be helpful. The other thing I noticed is that with
the patch method will throw a HiveException instead of SemanticException at line. May not
be a issue but worth investigating I think.

> MSCK Repair Requires nonstrict hive.mapred.mode
> -----------------------------------------------
>
>                 Key: HIVE-16024
>                 URL: https://issues.apache.org/jira/browse/HIVE-16024
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 2.2.0
>            Reporter: Barna Zsombor Klara
>            Assignee: Barna Zsombor Klara
>         Attachments: HIVE-16024.01.patch
>
>
> MSCK repair fails when hive.mapred.mode is set to strict
> HIVE-13788 modified the way we read up partitions for a table to improve performance.
Unfortunately it is using PartitionPruner to load the partitions which in turn is checking
hive.mapred.mode.
> The previous code did not check hive.mapred.mode.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message