hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-15873) Remove Windows-specific code
Date Sun, 12 Feb 2017 04:10:42 GMT

    [ https://issues.apache.org/jira/browse/HIVE-15873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862637#comment-15862637
] 

Ashutosh Chauhan commented on HIVE-15873:
-----------------------------------------

This indeed is pretty useful. Removing dead code is necessary to keep project healthy. 
Since its not most interesting bit of project, refactoring like these doesn't always happen
on time. Thanks a lot for taking time to do this and helping in moving project forward leaving
behind dead weight.

> Remove Windows-specific code
> ----------------------------
>
>                 Key: HIVE-15873
>                 URL: https://issues.apache.org/jira/browse/HIVE-15873
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Gunther Hagleitner
>            Assignee: Gunther Hagleitner
>             Fix For: 2.2.0
>
>         Attachments: HIVE-15873.1.patch, HIVE-15873.2.patch
>
>
> I know a lot of work has gone initially into supporting UT, runtime, etc on Windows,
but this code seems to have been rotting. 
> There have been no updates to the windows specific test files, or any new code to keep
the new features compatible.
> We're also not running the tests or builds on windows. That is really an impediment to
keepting that code healthy.
> The code is sprinkled all over the codebase. Makes it hard to maintain. I think we're
better off removing it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message