hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas M Nair (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session
Date Fri, 10 Feb 2017 06:26:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860814#comment-15860814
] 

Thejas M Nair commented on HIVE-15858:
--------------------------------------

bq.  It looks like we have two places in Beeline code to handles signals like Ctrl^C. 1. SunSignalHandler
and the code section which is modified by the patch. Do you think it would be a good idea
modify the code so that they are all handled at the same place?

While the description talks about ^C, I think this closing of session is something we should
be doing on any reason for exit. So the shutdownhook is the better place for that in my opinion.
For the desired behavior described in HIVE-15626  for ^C, that would need to be dealt with
in signalhandler.
So I think it makes sense to handle this two different requirements in two different places.


> Beeline ^C doesn't close the session
> ------------------------------------
>
>                 Key: HIVE-15858
>                 URL: https://issues.apache.org/jira/browse/HIVE-15858
>             Project: Hive
>          Issue Type: Bug
>          Components: Beeline
>            Reporter: Sankar Hariappan
>            Assignee: Sankar Hariappan
>         Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to close the
client using !quit or ^C command, it looks like all the connections/sessions are not getting
closed.
> !quit seems to close the current active connection but fails to close other open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport (hive.server2.transport.mode=http).
In case of BINARY mode, server triggers the close session when a tcp connection is closed
by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message