hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pengcheng Xiong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-15765) Support bracketed comments
Date Thu, 02 Feb 2017 01:28:51 GMT

    [ https://issues.apache.org/jira/browse/HIVE-15765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849234#comment-15849234
] 

Pengcheng Xiong commented on HIVE-15765:
----------------------------------------

The patch LGTM. Please take a look at the failing tests. 

> Support bracketed comments
> --------------------------
>
>                 Key: HIVE-15765
>                 URL: https://issues.apache.org/jira/browse/HIVE-15765
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Gunther Hagleitner
>            Assignee: Gunther Hagleitner
>         Attachments: HIVE-15765.1.patch, HIVE-15765.1.patch
>
>
> C-style comments are in the SQL spec as well as supported by all major DBs. The are useful
for inline annotation of the SQL. We should have them too.
> Example:
> {noformat}
> select
> /*+ MAPJOIN(a) */ /* mapjoin hint */
> a /* column */
> from foo join bar;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message