hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcelo Vanzin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-15671) RPCServer.registerClient() erroneously uses server/client handshake timeout for connection timeout
Date Fri, 10 Feb 2017 18:06:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-15671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861611#comment-15861611
] 

Marcelo Vanzin commented on HIVE-15671:
---------------------------------------

bq. I was talking about server detecting a driver problem after it has connected back to the
server.

Hmm. That is definitely not any of the "connect" timeouts, which probably means it isn't configured
and is just using netty's default (which is probably no timeout?). Would probably need something
using {{io.netty.handler.timeout.IdleStateHandler}}, and also some periodic "ping" so that
the connection isn't torn down without reason.

> RPCServer.registerClient() erroneously uses server/client handshake timeout for connection
timeout
> --------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-15671
>                 URL: https://issues.apache.org/jira/browse/HIVE-15671
>             Project: Hive
>          Issue Type: Bug
>          Components: Spark
>    Affects Versions: 1.1.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>         Attachments: HIVE-15671.1.patch, HIVE-15671.patch
>
>
> {code}
>   /**
>    * Tells the RPC server to expect a connection from a new client.
>    * ...
>    */
>   public Future<Rpc> registerClient(final String clientId, String secret,
>       RpcDispatcher serverDispatcher) {
>     return registerClient(clientId, secret, serverDispatcher, config.getServerConnectTimeoutMs());
>   }
> {code}
> {{config.getServerConnectTimeoutMs()}} returns value for *hive.spark.client.server.connect.timeout*,
which is meant for timeout for handshake between Hive client and remote Spark driver. Instead,
the timeout should be *hive.spark.client.connect.timeout*, which is for timeout for remote
Spark driver in connecting back to Hive client.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message