hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14016) Vectorization: Add support for Grouping Sets
Date Tue, 14 Feb 2017 05:39:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865106#comment-15865106
] 

Hive QA commented on HIVE-14016:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12852487/HIVE-14016.06.patch

{color:green}SUCCESS:{color} +1 due to 22 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 10223 tests executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_empty_where] (batchId=22)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan] (batchId=153)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=223)
org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver
(batchId=105)
org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver
(batchId=121)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_15] (batchId=122)
org.apache.hive.service.server.TestHS2HttpServer.testContextRootUrlRewrite (batchId=186)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3528/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3528/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3528/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12852487 - PreCommit-HIVE-Build

> Vectorization: Add support for Grouping Sets
> --------------------------------------------
>
>                 Key: HIVE-14016
>                 URL: https://issues.apache.org/jira/browse/HIVE-14016
>             Project: Hive
>          Issue Type: Improvement
>          Components: Vectorization
>            Reporter: Gopal V
>            Assignee: Matt McCline
>         Attachments: HIVE-14016.01.patch, HIVE-14016.02.patch, HIVE-14016.03.patch, HIVE-14016.04.patch,
HIVE-14016.05.patch, HIVE-14016.06.patch
>
>
> Rollup and Cube queries are not vectorized today due to the miss of grouping-sets inside
vector group by.
> The cube and rollup operators can be shimmed onto the end of the pipeline by converting
a single row writer into a multiple row writer.
> The corresponding non-vec loop is as follows
> {code}
>       if (groupingSetsPresent) {
>         Object[] newKeysArray = newKeys.getKeyArray();
>         Object[] cloneNewKeysArray = new Object[newKeysArray.length];
>         for (int keyPos = 0; keyPos < groupingSetsPosition; keyPos++) {
>           cloneNewKeysArray[keyPos] = newKeysArray[keyPos];
>         }
>         for (int groupingSetPos = 0; groupingSetPos < groupingSets.size(); groupingSetPos++)
{
>           for (int keyPos = 0; keyPos < groupingSetsPosition; keyPos++) {
>             newKeysArray[keyPos] = null;
>           }
>           FastBitSet bitset = groupingSetsBitSet[groupingSetPos];
>           // Some keys need to be left to null corresponding to that grouping set.
>           for (int keyPos = bitset.nextSetBit(0); keyPos >= 0;
>             keyPos = bitset.nextSetBit(keyPos+1)) {
>             newKeysArray[keyPos] = cloneNewKeysArray[keyPos];
>           }
>           newKeysArray[groupingSetsPosition] = newKeysGroupingSets[groupingSetPos];
>           processKey(row, rowInspector);
>         }
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message