hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcelo Vanzin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-15671) RPCServer.registerClient() erroneously uses server/client handshake timeout for connection timeout
Date Fri, 20 Jan 2017 03:31:26 GMT

    [ https://issues.apache.org/jira/browse/HIVE-15671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831115#comment-15831115
] 

Marcelo Vanzin edited comment on HIVE-15671 at 1/20/17 3:30 AM:
----------------------------------------------------------------

Hmm, the options are poorly named (my fault, and they always confuse me when I look at them
now), but the current use looks correct.

"client.connect.timeout" is for the connection that the Spark driver opens to HS2.
"server.connect.timeout" is actually used in two places, but is basically the time allowed
between HS2 starting the Spark driver, and the SASL handshake to finish.


was (Author: vanzin):
Hmm, the options are poorly named (my fault, and they always confuse me when I look at them
now), but the current use looks correct.

"client.connect.timeout" is for the connection that the Spark driver opens to HS2.
"server.connect.timeout" is actually used in both places, but is basically the time allowed
between HS2 starting the Spark driver, and the SASL handshake to finish.

> RPCServer.registerClient() erroneously uses server/client handshake timeout for connection
timeout
> --------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-15671
>                 URL: https://issues.apache.org/jira/browse/HIVE-15671
>             Project: Hive
>          Issue Type: Bug
>          Components: Spark
>    Affects Versions: 1.1.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>         Attachments: HIVE-15671.patch
>
>
> {code}
>   /**
>    * Tells the RPC server to expect a connection from a new client.
>    * ...
>    */
>   public Future<Rpc> registerClient(final String clientId, String secret,
>       RpcDispatcher serverDispatcher) {
>     return registerClient(clientId, secret, serverDispatcher, config.getServerConnectTimeoutMs());
>   }
> {code}
> {{config.getServerConnectTimeoutMs()}} returns value for *hive.spark.client.server.connect.timeout*,
which is meant for timeout for handshake between Hive client and remote Spark driver. Instead,
the timeout should be *hive.spark.client.connect.timeout*, which is for timeout for remote
Spark driver in connecting back to Hive client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message