Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D1768200BE8 for ; Fri, 23 Dec 2016 10:11:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CFFF5160B1E; Fri, 23 Dec 2016 09:11:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4AD2C160B1D for ; Fri, 23 Dec 2016 10:11:59 +0100 (CET) Received: (qmail 82686 invoked by uid 500); 23 Dec 2016 09:11:58 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 82593 invoked by uid 99); 23 Dec 2016 09:11:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Dec 2016 09:11:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5D0662C1F56 for ; Fri, 23 Dec 2016 09:11:58 +0000 (UTC) Date: Fri, 23 Dec 2016 09:11:58 +0000 (UTC) From: "Prasanth Jayachandran (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-15503) LLAP: Fix use of Runtime.getRuntime.maxMemory in Hive operators MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 23 Dec 2016 09:12:00 -0000 [ https://issues.apache.org/jira/browse/HIVE-15503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772377#comment-15772377 ] Prasanth Jayachandran commented on HIVE-15503: ---------------------------------------------- RB link: https://reviews.apache.org/r/55010/ [~hagleitn] can you please review the patch? > LLAP: Fix use of Runtime.getRuntime.maxMemory in Hive operators > --------------------------------------------------------------- > > Key: HIVE-15503 > URL: https://issues.apache.org/jira/browse/HIVE-15503 > Project: Hive > Issue Type: Bug > Affects Versions: 2.2.0 > Reporter: Prasanth Jayachandran > Assignee: Prasanth Jayachandran > Priority: Critical > Attachments: HIVE-15503.1.patch, HIVE-15503.2.patch, HIVE-15503.WIP.patch > > > {code} > ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java: maxHashTblMemory = (long) (memoryPercentage * Runtime.getRuntime().maxMemory()); > ql/src/java/org/apache/hadoop/hive/ql/exec/TopNHash.java: // Total Free Memory = maxMemory() - Used Memory; > ql/src/java/org/apache/hadoop/hive/ql/exec/TopNHash.java: long totalFreeMemory = Runtime.getRuntime().maxMemory() - > {code} > This will not work very well with LLAP because of the memory sharing by executors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)