Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BD2B4200BE5 for ; Sat, 10 Dec 2016 02:59:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BBD04160B1E; Sat, 10 Dec 2016 01:59:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 37F19160B1D for ; Sat, 10 Dec 2016 02:59:59 +0100 (CET) Received: (qmail 57772 invoked by uid 500); 10 Dec 2016 01:59:58 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 57758 invoked by uid 99); 10 Dec 2016 01:59:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Dec 2016 01:59:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5084B2C0086 for ; Sat, 10 Dec 2016 01:59:58 +0000 (UTC) Date: Sat, 10 Dec 2016 01:59:58 +0000 (UTC) From: "Sergey Shelukhin (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-15405) Improve FileUtils.isPathWithinSubtree MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 10 Dec 2016 01:59:59 -0000 [ https://issues.apache.org/jira/browse/HIVE-15405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736990#comment-15736990 ] Sergey Shelukhin commented on HIVE-15405: ----------------------------------------- Nm, it looks like a newly broken test today in all jiras. +1 > Improve FileUtils.isPathWithinSubtree > ------------------------------------- > > Key: HIVE-15405 > URL: https://issues.apache.org/jira/browse/HIVE-15405 > Project: Hive > Issue Type: Improvement > Reporter: Rajesh Balamohan > Assignee: Rajesh Balamohan > Priority: Minor > Attachments: HIVE-15405-profiler.view.png, HIVE-15405.1.patch, HIVE-15405.2.patch > > > When running single node LLAP with the following query multiple number of times (flights table had 7000+ partitions) {{FileUtils.isPathWithinSubtree}} became a hotpath. > {noformat} > SELECT COUNT(`flightnum`) AS `cnt_flightnum_ok`, > YEAR(`flights`.`dateofflight`) AS `yr_flightdate_ok` > FROM `flights` as `flights` > JOIN `airlines` ON (`uniquecarrier` = `airlines`.`code`) > JOIN `airports` as `source_airport` ON (`origin` = `source_airport`.`iata`) > JOIN `airports` as `dest_airport` ON (`flights`.`dest` = `dest_airport`.`iata`) > GROUP BY YEAR(`flights`.`dateofflight`); > {noformat} > It would be good to have early exit in {{FileUtils.isPathWithinSubtree}} based on path depth comparison. -- This message was sent by Atlassian JIRA (v6.3.4#6332)