Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Fri, 9 Dec 2016 13:25:58 +0000 (UTC)
From: "Hive QA (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.13026915.1481273843000.483334.1481289958344@Atlassian.JIRA>
In-Reply-To: <JIRA.13026915.1481273843000@Atlassian.JIRA>
References: <JIRA.13026915.1481273843000@Atlassian.JIRA> <JIRA.13026915.1481273843035@arcas>
Subject: [jira] [Commented] (HIVE-15405) Improve
 FileUtils.isPathWithinSubtree
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 09 Dec 2016 13:26:00 -0000


    [ https://issues.apache.org/jira/browse/HIVE-15405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735303#comment-15735303 ] 

Hive QA commented on HIVE-15405:
--------------------------------


Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12842517/HIVE-15405.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10792 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample2] (batchId=5)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample4] (batchId=15)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample6] (batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample7] (batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample9] (batchId=38)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic] (batchId=132)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[transform_ppr2] (batchId=134)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[stats_based_fetch_decision] (batchId=150)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2519/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2519/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2519/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12842517 - PreCommit-HIVE-Build

> Improve FileUtils.isPathWithinSubtree
> -------------------------------------
>
>                 Key: HIVE-15405
>                 URL: https://issues.apache.org/jira/browse/HIVE-15405
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>            Priority: Minor
>         Attachments: HIVE-15405-profiler.view.png, HIVE-15405.1.patch, HIVE-15405.2.patch
>
>
> When running single node LLAP with the following query multiple number of times (flights table had 7000+ partitions) {{FileUtils.isPathWithinSubtree}} became a hotpath. 
> {noformat}
> SELECT COUNT(`flightnum`) AS `cnt_flightnum_ok`,
> YEAR(`flights`.`dateofflight`) AS `yr_flightdate_ok`
> FROM `flights` as `flights`
> JOIN `airlines` ON (`uniquecarrier` = `airlines`.`code`)
> JOIN `airports` as `source_airport` ON (`origin` = `source_airport`.`iata`)
> JOIN `airports` as `dest_airport` ON (`flights`.`dest` = `dest_airport`.`iata`)
> GROUP BY YEAR(`flights`.`dateofflight`);
> {noformat}
> It would be good to have early exit in {{FileUtils.isPathWithinSubtree}} based on path depth comparison.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)