Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E8CF9200BD5 for ; Thu, 8 Dec 2016 16:46:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E78C1160B30; Thu, 8 Dec 2016 15:46:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3EAE8160B0A for ; Thu, 8 Dec 2016 16:46:59 +0100 (CET) Received: (qmail 90407 invoked by uid 500); 8 Dec 2016 15:46:58 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 90394 invoked by uid 99); 8 Dec 2016 15:46:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2016 15:46:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5EDF02C0079 for ; Thu, 8 Dec 2016 15:46:58 +0000 (UTC) Date: Thu, 8 Dec 2016 15:46:58 +0000 (UTC) From: "Abhishek Somani (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HIVE-15390) Orc reader unnecessarily reading stripe footers with hive.optimize.index.filter set to true MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 08 Dec 2016 15:47:00 -0000 [ https://issues.apache.org/jira/browse/HIVE-15390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732553#comment-15732553 ] Abhishek Somani edited comment on HIVE-15390 at 12/8/16 3:46 PM: ----------------------------------------------------------------- Attaching a patch removing the resetting of the maxOffset to Long.MAX_VALUE was (Author: asomani): Attaching a patch removing the resetting of the split's maxOffset to Long.MAX_VALUE > Orc reader unnecessarily reading stripe footers with hive.optimize.index.filter set to true > ------------------------------------------------------------------------------------------- > > Key: HIVE-15390 > URL: https://issues.apache.org/jira/browse/HIVE-15390 > Project: Hive > Issue Type: Bug > Components: ORC > Affects Versions: 1.2.1 > Reporter: Abhishek Somani > Assignee: Abhishek Somani > Attachments: HIVE-15390.patch > > > In a split given to a task, the task's orc reader is unnecessarily reading stripe footers for stripes that are not its responsibility to read. This is happening with hive.optimize.index.filter set to true. > Assuming one split per task(no tez grouping considered), a task should not need to read beyond the split's end offset. Even in some split computation strategies where a split's end offset can be in the middle of a stripe, it should not need to read more than one stripe beyond the split's end offset(to fully read a stripe that started in it). However I see that some tasks make unnecessary filesystem calls to read all the stripe footers in a file from the split start offset till the end of the file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)