hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anthony Hsu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-15353) Metastore throws NPE if StorageDescriptor.cols is null
Date Thu, 08 Dec 2016 21:32:58 GMT

    [ https://issues.apache.org/jira/browse/HIVE-15353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733427#comment-15733427
] 

Anthony Hsu edited comment on HIVE-15353 at 12/8/16 9:32 PM:
-------------------------------------------------------------

Uploaded new patch.

After further offline discussion with [~cwsteinbach], we decided updating the Thrift API was
not the right approach, given that {{cols}} should always be set. {{add_partition}} and {{alter_partition}}
should not accept partitions with null {{cols}} fields. This can be fixed in a follow-up ticket:
HIVE-15394. For now, this patch simply eliminates the NPEs on the metastore side.


was (Author: erwaman):
Uploaded new patch.

After further offline discussion with [~cwsteinbach], we decided updating the Thrift API was
not the right approach, given that {{cols}} should always be set. {{add_partition}} and {{alter_partition}}
should not accept partitions with null {{cols}} fields. This can be fixed in a follow-up ticket.
For now, this patch simply eliminates the NPEs on the metastore side.

> Metastore throws NPE if StorageDescriptor.cols is null
> ------------------------------------------------------
>
>                 Key: HIVE-15353
>                 URL: https://issues.apache.org/jira/browse/HIVE-15353
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 1.1.0, 2.2.0
>            Reporter: Anthony Hsu
>            Assignee: Anthony Hsu
>         Attachments: HIVE-15353.1.patch, HIVE-15353.2.patch, HIVE-15353.3.patch
>
>
> When using the HiveMetaStoreClient API directly to talk to the metastore, you get NullPointerExceptions
when StorageDescriptor.cols is null in the Table/Partition object in the following calls:
> * create_table
> * alter_table
> * alter_partition
> Calling add_partition with StorageDescriptor.cols set to null causes null to be stored
in the metastore database and subsequent calls to alter_partition for that partition to fail
with an NPE.
> Null checks should be added to eliminate the NPEs in the metastore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message