Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Mon, 28 Nov 2016 16:32:58 +0000 (UTC)
From: =?utf-8?Q?Sergio_Pe=C3=B1a_=28JIRA=29?= <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.13023066.1479951874000.379199.1480350778964@Atlassian.JIRA>
In-Reply-To: <JIRA.13023066.1479951874000@Atlassian.JIRA>
References: <JIRA.13023066.1479951874000@Atlassian.JIRA> <JIRA.13023066.1479951874981@arcas>
Subject: [jira] [Updated] (HIVE-15280) Hive.mvFile() misses the "." char
 when joining the filename + extension
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 28 Nov 2016 16:33:00 -0000


     [ https://issues.apache.org/jira/browse/HIVE-15280?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergio Pe=C3=B1a updated HIVE-15280:
-------------------------------
    Attachment: HIVE-15280.2.patch

[~stakiar] I added a new test case to the S3 insert_into.q query to validat=
e the compressed filenames are correctly inserted.

I thought on adding this case on insert_compressed.q, but the {{dfs -ls}} c=
ommand on .q.out for HDFS patches are fully masked, and if I change it to b=
e partially masked, then lots of .q.out would need to be updated.

I also thought about adding simple unit tests with mocks, but mvFile and co=
pyFiles are private methods, and another parent copyFiles is protected, and=
 that just complicates unit tests.=20

I think the insert_compressed.q did not fail on Hive 2.2 because it fixed s=
omething related to detecting compression on files without looking at the f=
ile extension.=20

Anyway, I had an idea of making blobstore tests available on Hive QA by add=
ing a proxy filesystem to it. Once I do that, we will see these tests runni=
ng automatically, and validating the mvFile() case.

> Hive.mvFile() misses the "." char when joining the filename + extension
> -----------------------------------------------------------------------
>
>                 Key: HIVE-15280
>                 URL: https://issues.apache.org/jira/browse/HIVE-15280
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Sergio Pe=C3=B1a
>            Assignee: Sergio Pe=C3=B1a
>            Priority: Critical
>         Attachments: HIVE-15280.1.patch, HIVE-15280.2.patch
>
>
> Hive.mvFile() misses the "." char when joining the filename + extension. =
This may cause incorrect results when compressed files are copied to a tabl=
e location.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)