Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Thu, 17 Nov 2016 17:48:58 +0000 (UTC)
From: "Mohit Sabharwal (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.13021312.1479340984000.305541.1479404938408@Atlassian.JIRA>
In-Reply-To: <JIRA.13021312.1479340984000@Atlassian.JIRA>
References: <JIRA.13021312.1479340984000@Atlassian.JIRA> <JIRA.13021312.1479340984853@arcas>
Subject: [jira] [Commented] (HIVE-15226) Add a different masking comment to
 qtests blobstore output
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 17 Nov 2016 17:49:00 -0000


    [ https://issues.apache.org/jira/browse/HIVE-15226?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1567=
4344#comment-15674344 ]=20

Mohit Sabharwal commented on HIVE-15226:
----------------------------------------

LGTM +1

(I'm assuming addPatternWithMaskComment is called at most once for each uni=
que pattern).

> Add a different masking comment to qtests blobstore output
> ----------------------------------------------------------
>
>                 Key: HIVE-15226
>                 URL: https://issues.apache.org/jira/browse/HIVE-15226
>             Project: Hive
>          Issue Type: Task
>          Components: Hive
>            Reporter: Sergio Pe=C3=B1a
>            Assignee: Sergio Pe=C3=B1a
>            Priority: Minor
>         Attachments: HIVE-15226.1.patch, HIVE-15226.2.patch
>
>
> The output of TestBlobstoreCliDriver is masking all s3a patch so that we =
can use the tests with any other blobstore scheme.
> It should be good to have a specific masking comment for those paths inst=
ead of the generic "#### A masked pattern was here ####" so that we can ver=
ify that certain tests are indeed using the blobstore path.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)