Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Sun, 20 Nov 2016 20:31:58 +0000 (UTC)
From: "Hive QA (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12964903.1462347749000.323375.1479673918985@Atlassian.JIRA>
In-Reply-To: <JIRA.12964903.1462347749000@Atlassian.JIRA>
References: <JIRA.12964903.1462347749000@Atlassian.JIRA> <JIRA.12964903.1462347749492@arcas>
Subject: [jira] [Commented] (HIVE-13685) Vectorization: Date*ColScalar
 parses the scalar in every loop
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 20 Nov 2016 20:32:01 -0000


    [ https://issues.apache.org/jira/browse/HIVE-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15681796#comment-15681796 ] 

Hive QA commented on HIVE-13685:
--------------------------------


Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12816757/HIVE-13685.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10698 tests executed
*Failed tests:*
{noformat}
TestSparkCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=111)
	[bucketmapjoin3.q,union_date.q,cbo_gby.q,auto_join31.q,auto_sortmerge_join_1.q,join_cond_pushdown_unqual1.q,ppd_outer_join3.q,bucket_map_join_spark3.q,union28.q,statsfs.q,escape_sortby1.q,leftsemijoin.q,groupby_multi_single_reducer3.q,union_remove_6.q,join29.q]
TestSparkCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=116)
	[load_dyn_part2.q,smb_mapjoin_7.q,vectorization_5.q,smb_mapjoin_2.q,ppd_join_filter.q,column_access_stats.q,vector_between_in.q,vectorized_string_funcs.q,vectorization_1.q,bucket_map_join_2.q,groupby4_map_skew.q,groupby_ppr_multi_distinct.q,temp_table_join1.q,vectorized_case.q,stats_noscan_1.q]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_sortmerge_join_2] (batchId=43)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a] (batchId=133)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[transform_ppr2] (batchId=133)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join_acid_non_acid] (batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=145)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2217/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2217/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2217/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12816757 - PreCommit-HIVE-Build

> Vectorization: Date*ColScalar parses the scalar in every loop
> -------------------------------------------------------------
>
>                 Key: HIVE-13685
>                 URL: https://issues.apache.org/jira/browse/HIVE-13685
>             Project: Hive
>          Issue Type: Improvement
>          Components: Vectorization
>    Affects Versions: 2.1.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>         Attachments: HIVE-13685.1.patch, HIVE-13685.2.patch, HIVE-13685.WIP.patch
>
>
> {code}
> @Override
>   public void evaluate(VectorizedRowBatch batch) {
> ...
> switch (inputTypes[0]) {
> ...
>       case STRING:
>       case CHAR:
>       case VARCHAR:
>         try {
>           baseDate = formatter.parse(new String(stringValue, "UTF-8"));
>           break;
> {code}
> This is parsing the constant scalar for every evaluate() call.
> Parsing the constant in the initialize op will save thousands of expensive calls into Calendar operations.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)