hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergio Peña (JIRA) <j...@apache.org>
Subject [jira] [Updated] (HIVE-15280) Hive.mvFile() misses the "." char when joining the filename + extension
Date Mon, 28 Nov 2016 16:32:58 GMT

     [ https://issues.apache.org/jira/browse/HIVE-15280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sergio Peña updated HIVE-15280:
-------------------------------
    Attachment: HIVE-15280.2.patch

[~stakiar] I added a new test case to the S3 insert_into.q query to validate the compressed
filenames are correctly inserted.

I thought on adding this case on insert_compressed.q, but the {{dfs -ls}} command on .q.out
for HDFS patches are fully masked, and if I change it to be partially masked, then lots of
.q.out would need to be updated.

I also thought about adding simple unit tests with mocks, but mvFile and copyFiles are private
methods, and another parent copyFiles is protected, and that just complicates unit tests.


I think the insert_compressed.q did not fail on Hive 2.2 because it fixed something related
to detecting compression on files without looking at the file extension. 

Anyway, I had an idea of making blobstore tests available on Hive QA by adding a proxy filesystem
to it. Once I do that, we will see these tests running automatically, and validating the mvFile()
case.

> Hive.mvFile() misses the "." char when joining the filename + extension
> -----------------------------------------------------------------------
>
>                 Key: HIVE-15280
>                 URL: https://issues.apache.org/jira/browse/HIVE-15280
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Sergio Peña
>            Assignee: Sergio Peña
>            Priority: Critical
>         Attachments: HIVE-15280.1.patch, HIVE-15280.2.patch
>
>
> Hive.mvFile() misses the "." char when joining the filename + extension. This may cause
incorrect results when compressed files are copied to a table location.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message