hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sahil Takiar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-15226) Add a different masking comment to qtests blobstore output
Date Thu, 17 Nov 2016 00:31:58 GMT

    [ https://issues.apache.org/jira/browse/HIVE-15226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672205#comment-15672205
] 

Sahil Takiar commented on HIVE-15226:
-------------------------------------

Overall looks good. Only comment is that {{patternsWithMaskComments}} should probably return
a {{Pair<Pattern, String>}} instead of a {{String[][]}}. {{Pattern.compile(...)}} is
an expensive call, so you really only want to do it once per Hive QA run.

> Add a different masking comment to qtests blobstore output
> ----------------------------------------------------------
>
>                 Key: HIVE-15226
>                 URL: https://issues.apache.org/jira/browse/HIVE-15226
>             Project: Hive
>          Issue Type: Task
>          Components: Hive
>            Reporter: Sergio Peña
>            Assignee: Sergio Peña
>            Priority: Minor
>         Attachments: HIVE-15226.1.patch
>
>
> The output of TestBlobstoreCliDriver is masking all s3a patch so that we can use the
tests with any other blobstore scheme.
> It should be good to have a specific masking comment for those paths instead of the generic
"#### A masked pattern was here ####" so that we can verify that certain tests are indeed
using the blobstore path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message