hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohit Sabharwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-13966) DbNotificationListener: can loose DDL operation notifications
Date Mon, 07 Nov 2016 23:44:59 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645839#comment-15645839
] 

Mohit Sabharwal commented on HIVE-13966:
----------------------------------------

[~alangates], [~sushanth], [~ctang.ma], could you please take a look at the latest patch ?

I updated RB at https://reviews.apache.org/r/52800/

Filed HIVE-15145 for a related issue that I saw while I was looking at HiveAlterTable.

> DbNotificationListener: can loose DDL operation notifications
> -------------------------------------------------------------
>
>                 Key: HIVE-13966
>                 URL: https://issues.apache.org/jira/browse/HIVE-13966
>             Project: Hive
>          Issue Type: Bug
>          Components: HCatalog
>            Reporter: Nachiket Vaidya
>            Assignee: Mohit Sabharwal
>            Priority: Critical
>         Attachments: HIVE-13966.1.patch, HIVE-13966.2.patch, HIVE-13966.3.patch, HIVE-13966.4.patch,
HIVE-13966.pdf
>
>
> The code for each API in HiveMetaStore.java is like this:
> 1. openTransaction()
> 2. -- operation--
> 3. commit() or rollback() based on result of the operation.
> 4. add entry to notification log (unconditionally)
> If the operation is failed (in step 2), we still add entry to notification log. Found
this issue in testing.
> It is still ok as this is the case of false positive.
> If the operation is successful and adding to notification log failed, the user will get
an MetaException. It will not rollback the operation, as it is already committed. We need
to handle this case so that we will not have false negatives.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message