Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Mon, 24 Oct 2016 23:28:59 +0000 (UTC)
From: "Sergey Shelukhin (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.13014924.1477351609000.72709.1477351739284@Atlassian.JIRA>
In-Reply-To: <JIRA.13014924.1477351609000@Atlassian.JIRA>
References: <JIRA.13014924.1477351609000@Atlassian.JIRA> <JIRA.13014924.1477351609553@arcas>
Subject: [jira] [Updated] (HIVE-15047) metastore setconf API can set too
 many confs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 24 Oct 2016 23:29:01 -0000


     [ https://issues.apache.org/jira/browse/HIVE-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergey Shelukhin updated HIVE-15047:
------------------------------------
    Description: 
{noformat}
    public void setMetaConf(String key, String value) throws MetaException {
      ConfVars confVar = HiveConf.getMetaConf(key);
{noformat}
that gets stuff from "metaConfs", which contains all the metastore configs, including the warehouse location, port (setting that unfortunately would not work; imagine the possibilities!), etc.
There's another small list near metaConfs - metaConfVars, billed as "User configurable Metastore vars". That is probably the list that was intended for the above API; as it is, it's not used for any checks.
When making the change SetProcessor etc. should be adjusted to fail with some user-friendly message when trying to set unsettable metastore configs.


  was:
{noformat}
    public void setMetaConf(String key, String value) throws MetaException {
      ConfVars confVar = HiveConf.getMetaConf(key);
{noformat}
that gets stuff from "metaConfs", which contains all the metastore configs, including the warehouse location, port (setting that unfortunately would not work; imagine the possibilities!), etc.
There's another small list near metaConfs - metaConfVars, billed as "User configurable Metastore vars". That is probably the list that should be used; as it is, it's not used for any checks.
When making the change SetProcessor etc. should be adjusted to fail with some user-friendly message when trying to set unsettable metastore APIs.


{noformat}


> metastore setconf API can set too many confs
> --------------------------------------------
>
>                 Key: HIVE-15047
>                 URL: https://issues.apache.org/jira/browse/HIVE-15047
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>
> {noformat}
>     public void setMetaConf(String key, String value) throws MetaException {
>       ConfVars confVar = HiveConf.getMetaConf(key);
> {noformat}
> that gets stuff from "metaConfs", which contains all the metastore configs, including the warehouse location, port (setting that unfortunately would not work; imagine the possibilities!), etc.
> There's another small list near metaConfs - metaConfVars, billed as "User configurable Metastore vars". That is probably the list that was intended for the above API; as it is, it's not used for any checks.
> When making the change SetProcessor etc. should be adjusted to fail with some user-friendly message when trying to set unsettable metastore configs.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)