Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D2B60200BAA for ; Wed, 12 Oct 2016 23:06:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D0E75160ACA; Wed, 12 Oct 2016 21:06:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5275E160AEE for ; Wed, 12 Oct 2016 23:06:23 +0200 (CEST) Received: (qmail 50332 invoked by uid 500); 12 Oct 2016 21:06:22 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 50267 invoked by uid 99); 12 Oct 2016 21:06:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Oct 2016 21:06:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 137CD2C4C75 for ; Wed, 12 Oct 2016 21:06:22 +0000 (UTC) Date: Wed, 12 Oct 2016 21:06:22 +0000 (UTC) From: "Pengcheng Xiong (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-14872) Remove the configuration HIVE_SUPPORT_SQL11_RESERVED_KEYWORDS MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 12 Oct 2016 21:06:24 -0000 [ https://issues.apache.org/jira/browse/HIVE-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pengcheng Xiong updated HIVE-14872: ----------------------------------- Fix Version/s: 2.2.0 > Remove the configuration HIVE_SUPPORT_SQL11_RESERVED_KEYWORDS > ------------------------------------------------------------- > > Key: HIVE-14872 > URL: https://issues.apache.org/jira/browse/HIVE-14872 > Project: Hive > Issue Type: Sub-task > Components: Parser > Affects Versions: 2.1.0 > Reporter: Pengcheng Xiong > Assignee: Pengcheng Xiong > Fix For: 2.2.0 > > Attachments: HIVE-14872.01.patch, HIVE-14872.02.patch > > > The main purpose for the configuration of HIVE_SUPPORT_SQL11_RESERVED_KEYWORDS is for backward compatibility because a lot of reserved key words has been used as identifiers in the previous releases. We already have had several releases with this configuration. Now when I tried to add new set operators to the parser, ANTLR is always complaining "code too large". I think it is time to remove this configuration. (1) It will simplify the parser logic and largely reduce the size of generated parser code; (2) it leave space for new features, especially those which require parser changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)