Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 24026200BB4 for ; Mon, 17 Oct 2016 16:51:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 21C9D160AE5; Mon, 17 Oct 2016 14:51:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 68439160AEC for ; Mon, 17 Oct 2016 16:50:59 +0200 (CEST) Received: (qmail 42955 invoked by uid 500); 17 Oct 2016 14:50:58 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 42940 invoked by uid 99); 17 Oct 2016 14:50:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Oct 2016 14:50:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 62F972C4C74 for ; Mon, 17 Oct 2016 14:50:58 +0000 (UTC) Date: Mon, 17 Oct 2016 14:50:58 +0000 (UTC) From: =?utf-8?Q?Sergio_Pe=C3=B1a_=28JIRA=29?= To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-14864) Distcp is not called from MoveTask when src is a directory MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 17 Oct 2016 14:51:00 -0000 [ https://issues.apache.org/jira/browse/HIVE-14864?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1558= 2459#comment-15582459 ]=20 Sergio Pe=C3=B1a commented on HIVE-14864: ------------------------------------ A couple of comments: * Will srcFS.getContentSummary(src) cause extra time when source is on S3? = If so, maybe we want to put this line inside the if() statement. * Once we're here, could you fix the message from HIVE_EXEC_COPYFILE_MAXSIZ= E to say (in Bytes) instead of (in Mb) ? > Distcp is not called from MoveTask when src is a directory > ---------------------------------------------------------- > > Key: HIVE-14864 > URL: https://issues.apache.org/jira/browse/HIVE-14864 > Project: Hive > Issue Type: Bug > Reporter: Vihang Karajgaonkar > Assignee: Sahil Takiar > Attachments: HIVE-14864.1.patch, HIVE-14864.2.patch, HIVE-14864.p= atch > > > In FileUtils.java the following code does not get executed even when src = directory size is greater than HIVE_EXEC_COPYFILE_MAXSIZE because=20 > srcFS.getFileStatus(src).getLen() returns 0 when src is a directory. We s= hould use srcFS.getContentSummary(src).getLength() instead. > {noformat} > /* Run distcp if source file/dir is too big */ > if (srcFS.getUri().getScheme().equals("hdfs") && > srcFS.getFileStatus(src).getLen() > conf.getLongVar(HiveConf.Conf= Vars.HIVE_EXEC_COPYFILE_MAXSIZE)) { > LOG.info("Source is " + srcFS.getFileStatus(src).getLen() + " bytes= . (MAX: " + conf.getLongVar(HiveConf.ConfVars.HIVE_EXEC_COPYFILE_MAXSIZE) += ")"); > LOG.info("Launch distributed copy (distcp) job."); > HiveConfUtil.updateJobCredentialProviders(conf); > copied =3D shims.runDistCp(src, dst, conf); > if (copied && deleteSource) { > srcFS.delete(src, true); > } > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)