hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-15047) metastore setconf API can set too many confs
Date Mon, 24 Oct 2016 23:28:59 GMT

     [ https://issues.apache.org/jira/browse/HIVE-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sergey Shelukhin updated HIVE-15047:
------------------------------------
    Description: 
{noformat}
    public void setMetaConf(String key, String value) throws MetaException {
      ConfVars confVar = HiveConf.getMetaConf(key);
{noformat}
that gets stuff from "metaConfs", which contains all the metastore configs, including the
warehouse location, port (setting that unfortunately would not work; imagine the possibilities!),
etc.
There's another small list near metaConfs - metaConfVars, billed as "User configurable Metastore
vars". That is probably the list that was intended for the above API; as it is, it's not used
for any checks.
When making the change SetProcessor etc. should be adjusted to fail with some user-friendly
message when trying to set unsettable metastore configs.





  was:
{noformat}
    public void setMetaConf(String key, String value) throws MetaException {
      ConfVars confVar = HiveConf.getMetaConf(key);
{noformat}
that gets stuff from "metaConfs", which contains all the metastore configs, including the
warehouse location, port (setting that unfortunately would not work; imagine the possibilities!),
etc.
There's another small list near metaConfs - metaConfVars, billed as "User configurable Metastore
vars". That is probably the list that should be used; as it is, it's not used for any checks.
When making the change SetProcessor etc. should be adjusted to fail with some user-friendly
message when trying to set unsettable metastore APIs.




{noformat}


> metastore setconf API can set too many confs
> --------------------------------------------
>
>                 Key: HIVE-15047
>                 URL: https://issues.apache.org/jira/browse/HIVE-15047
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>
> {noformat}
>     public void setMetaConf(String key, String value) throws MetaException {
>       ConfVars confVar = HiveConf.getMetaConf(key);
> {noformat}
> that gets stuff from "metaConfs", which contains all the metastore configs, including
the warehouse location, port (setting that unfortunately would not work; imagine the possibilities!),
etc.
> There's another small list near metaConfs - metaConfVars, billed as "User configurable
Metastore vars". That is probably the list that was intended for the above API; as it is,
it's not used for any checks.
> When making the change SetProcessor etc. should be adjusted to fail with some user-friendly
message when trying to set unsettable metastore configs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message