hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanth Jayachandran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14968) Fix compilation failure on branch-1
Date Fri, 21 Oct 2016 17:50:58 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595839#comment-15595839
] 

Prasanth Jayachandran commented on HIVE-14968:
----------------------------------------------

lgtm, +1

bq. I see a LONG being casted to INT. Isn't going to have overflow issues if the LONG value
is too large to fit?
batchSize is not expected to be larger (1024 is default and not configurable). The cast is
required as batchSize is received as long but ensureSize() requires the batchSize as int.
This is fixed in master so master does not need explicit cast but branch-1 will need it. The
intent of HIVE-14483 is just to invoke ensureSize and the down casting is safe in this context
as batchSize is not expected to be >1024 inside of hive.

> Fix compilation failure on branch-1
> -----------------------------------
>
>                 Key: HIVE-14968
>                 URL: https://issues.apache.org/jira/browse/HIVE-14968
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 1.3.0
>
>         Attachments: HIVE-14968-branch-1.1.patch, HIVE-14968.1.patch
>
>
> branch-1 compilation failure due to:
> HIVE-14436: Hive 1.2.1/Hitting "ql.Driver: FAILED: IllegalArgumentException Error: ,
expected at the end of 'decimal(9'" after enabling hive.optimize.skewjoin and with MR engine
> HIVE-14483 : java.lang.ArrayIndexOutOfBoundsException org.apache.orc.impl.TreeReaderFactory.commonReadByteArrays
> 1.2 branch is fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message