hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chaoyu Tang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14927) Remove code duplication from tests in TestLdapAtnProviderWithMiniDS
Date Mon, 17 Oct 2016 22:48:58 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583744#comment-15583744
] 

Chaoyu Tang commented on HIVE-14927:
------------------------------------

Yeah, it seems that precommit build have some issues.

> Remove code duplication from tests in TestLdapAtnProviderWithMiniDS
> -------------------------------------------------------------------
>
>                 Key: HIVE-14927
>                 URL: https://issues.apache.org/jira/browse/HIVE-14927
>             Project: Hive
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Illya Yalovyy
>            Assignee: Illya Yalovyy
>         Attachments: HIVE-14927.1.patch, HIVE-14927.2.patch, HIVE-14927.3.patch
>
>
> * Extract inner class User and implement a proper builder for it.
> * Extract all common code to LdapAuthenticationTestCase class 
>   ** setting up the test case
>    ** executing test case
>    ** result validation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message