hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-14908) Upgrade ANTLR to 3.5.2
Date Fri, 07 Oct 2016 13:23:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554436#comment-15554436
] 

Zoltan Haindrich edited comment on HIVE-14908 at 10/7/16 1:22 PM:
------------------------------------------------------------------

I've also tried 3.5.2  while I experimented with interval fixes..it didnt helped in that neither
;)

But I was not sure about antlr upgrade preferences ...
So i think I will look into it...but not sure how hard it will be...now that I've tried it..there
are large differences.
but..antlr4 has much better dev tooling support which would be useful during development

althrough the removal of the optional reservation of these keywords will help - but I think
identifierparser should be split up
 [~pxiong] 


was (Author: kgyrtkirk):
I've also tried 3.5.2  while I experimented with interval fixes..it didnt helped in that neither
;)

But I was not sure about antlr upgrade preferences ... afaik antlr4 does syn rules automatically..
So i think it might worth a try - I think i will try it.
Antlr4 has much better dev tooling support which would be useful during development

althrough the removal of the optional reservation of these keywords will help - but I think
identifierparser should be split up
 [~pxiong] 

> Upgrade ANTLR to 3.5.2
> ----------------------
>
>                 Key: HIVE-14908
>                 URL: https://issues.apache.org/jira/browse/HIVE-14908
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Pengcheng Xiong
>            Assignee: Pengcheng Xiong
>         Attachments: HIVE-14908.01.patch
>
>
> Antlr v4 is also available but it does not support "->" which is widely used in our
grammar. Antlr 3.5.2 is the latest v3 version. It will reduce the code size:
> {code}
> Here is summary of current parser code size
> 422345  HiveLexer.java
> 2436601  HiveParser.java
> 814184  HiveParser_FromClauseParser.java
> 2705920  HiveParser_IdentifiersParser.java
> 777665 HiveParser_SelectClauseParser.java
>    After change, it will become
> 319589 HiveLexer.java
> 1853104 HiveParser.java
> 574156 HiveParser_FromClauseParser.java
> 1799195 HiveParser_IdentifiersParser.java
> 587305 HiveParser_SelectClauseParser.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message