hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14908) Upgrade ANTLR to 3.5.2
Date Fri, 07 Oct 2016 11:01:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554804#comment-15554804
] 

Hive QA commented on HIVE-14908:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12832091/HIVE-14908.01.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10656 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[columnstats_partlvl_multiple_part_clause]
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1425/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1425/console
Test logs: http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-Build-1425/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12832091 - PreCommit-HIVE-Build

> Upgrade ANTLR to 3.5.2
> ----------------------
>
>                 Key: HIVE-14908
>                 URL: https://issues.apache.org/jira/browse/HIVE-14908
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Pengcheng Xiong
>            Assignee: Pengcheng Xiong
>         Attachments: HIVE-14908.01.patch
>
>
> Antlr v4 is also available but it does not support "->" which is widely used in our
grammar. Antlr 3.5.2 is the latest v3 version. It will reduce the code size:
> {code}
> Here is summary of current parser code size
> 422345  HiveLexer.java
> 2436601  HiveParser.java
> 814184  HiveParser_FromClauseParser.java
> 2705920  HiveParser_IdentifiersParser.java
> 777665 HiveParser_SelectClauseParser.java
>    After change, it will become
> 319589 HiveLexer.java
> 1853104 HiveParser.java
> 574156 HiveParser_FromClauseParser.java
> 1799195 HiveParser_IdentifiersParser.java
> 587305 HiveParser_SelectClauseParser.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message