hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pengcheng Xiong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14872) Remove the configuration HIVE_SUPPORT_SQL11_RESERVED_KEYWORDS
Date Wed, 12 Oct 2016 21:05:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569871#comment-15569871
] 

Pengcheng Xiong commented on HIVE-14872:
----------------------------------------

update the golden file. Double check that it passed. pushed to master. Thanks [~ashutoshc]
for the review.

> Remove the configuration HIVE_SUPPORT_SQL11_RESERVED_KEYWORDS
> -------------------------------------------------------------
>
>                 Key: HIVE-14872
>                 URL: https://issues.apache.org/jira/browse/HIVE-14872
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Pengcheng Xiong
>            Assignee: Pengcheng Xiong
>         Attachments: HIVE-14872.01.patch, HIVE-14872.02.patch
>
>
> The main purpose for the configuration of HIVE_SUPPORT_SQL11_RESERVED_KEYWORDS is for
backward compatibility because a lot of reserved key words has been used as identifiers in
the previous releases. We already have had several releases with this configuration. Now when
I tried to add new set operators to the parser, ANTLR is always complaining "code too large".
I think it is time to remove this configuration. (1) It will simplify the parser logic and
largely reduce the size of generated parser code; (2) it leave space for new features, especially
those which require parser changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message