hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14872) Remove the configuration HIVE_SUPPORT_SQL11_RESERVED_KEYWORDS
Date Wed, 12 Oct 2016 12:02:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568529#comment-15568529
] 

Hive QA commented on HIVE-14872:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12832776/HIVE-14872.02.patch

{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 10484 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[udaf_collect_set_2]
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1497/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1497/console
Test logs: http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-Build-1497/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12832776 - PreCommit-HIVE-Build

> Remove the configuration HIVE_SUPPORT_SQL11_RESERVED_KEYWORDS
> -------------------------------------------------------------
>
>                 Key: HIVE-14872
>                 URL: https://issues.apache.org/jira/browse/HIVE-14872
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Pengcheng Xiong
>            Assignee: Pengcheng Xiong
>         Attachments: HIVE-14872.01.patch, HIVE-14872.02.patch
>
>
> The main purpose for the configuration of HIVE_SUPPORT_SQL11_RESERVED_KEYWORDS is for
backward compatibility because a lot of reserved key words has been used as identifiers in
the previous releases. We already have had several releases with this configuration. Now when
I tried to add new set operators to the parser, ANTLR is always complaining "code too large".
I think it is time to remove this configuration. (1) It will simplify the parser logic and
largely reduce the size of generated parser code; (2) it leave space for new features, especially
those which require parser changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message