Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 72E8A200B88 for ; Thu, 22 Sep 2016 23:50:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 71611160AE2; Thu, 22 Sep 2016 21:50:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DE974160AE0 for ; Thu, 22 Sep 2016 23:50:22 +0200 (CEST) Received: (qmail 4394 invoked by uid 500); 22 Sep 2016 21:50:22 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 4353 invoked by uid 99); 22 Sep 2016 21:50:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2016 21:50:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 00D542C2A63 for ; Thu, 22 Sep 2016 21:50:22 +0000 (UTC) Date: Thu, 22 Sep 2016 21:50:22 +0000 (UTC) From: "Illya Yalovyy (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-14713) LDAP Authentication Provider should be covered with unit tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 22 Sep 2016 21:50:23 -0000 [ https://issues.apache.org/jira/browse/HIVE-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514582#comment-15514582 ] Illya Yalovyy commented on HIVE-14713: -------------------------------------- [~szehon], [~ctang.ma], The CR got a "ship it", please advise what is the next step to get this patch accepted? > LDAP Authentication Provider should be covered with unit tests > -------------------------------------------------------------- > > Key: HIVE-14713 > URL: https://issues.apache.org/jira/browse/HIVE-14713 > Project: Hive > Issue Type: Test > Components: Authentication, Tests > Affects Versions: 2.1.0 > Reporter: Illya Yalovyy > Assignee: Illya Yalovyy > Attachments: HIVE-14713.1.patch, HIVE-14713.2.patch, HIVE-14713.3.patch > > > Currently LdapAuthenticationProviderImpl class is not covered with unit tests. To make this class testable some minor refactoring will be required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)