Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2E45D200B8D for ; Thu, 8 Sep 2016 19:33:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2AB96160ABD; Thu, 8 Sep 2016 17:33:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A195B160AAD for ; Thu, 8 Sep 2016 19:33:26 +0200 (CEST) Received: (qmail 95257 invoked by uid 500); 8 Sep 2016 17:33:21 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 95114 invoked by uid 99); 8 Sep 2016 17:33:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Sep 2016 17:33:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 4AE8E2C1B75 for ; Thu, 8 Sep 2016 17:33:21 +0000 (UTC) Date: Thu, 8 Sep 2016 17:33:21 +0000 (UTC) From: "Mohit Sabharwal (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-14011) MessageFactory is not pluggable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 08 Sep 2016 17:33:27 -0000 [ https://issues.apache.org/jira/browse/HIVE-14011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474501#comment-15474501 ] Mohit Sabharwal commented on HIVE-14011: ---------------------------------------- instance is private and only accessible via getInstance, so this it should always default to org.apache.hive.hcatalog.messaging.json.JSONMessageFactory which is the current behavior LGTM, +1 pending tests cc [~alangates] in case he has comments. > MessageFactory is not pluggable > ------------------------------- > > Key: HIVE-14011 > URL: https://issues.apache.org/jira/browse/HIVE-14011 > Project: Hive > Issue Type: Bug > Reporter: Sravya Tirukkovalur > Attachments: HIVE-14011.patch > > > Property "hcatalog.message.factory.impl.json" is available to use a custom message factory implementation. Although it is not pluggable as MessageFatcory is hardcoded to use JSONMessageFactory. > https://github.com/apache/hive/blob/26b5c7b56a4f28ce3eabc0207566cce46b29b558/hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/MessageFactory.java#L39 -- This message was sent by Atlassian JIRA (v6.3.4#6332)