hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14775) Investigate IOException usage in Metrics APIs
Date Fri, 30 Sep 2016 12:05:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15535810#comment-15535810
] 

Hive QA commented on HIVE-14775:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12831095/HIVE-14775.1.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 10651 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_mapjoin]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ctas]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char]
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
org.apache.hadoop.hive.metastore.TestMetaStoreMetrics.testMetaDataCounts
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1360/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1360/console
Test logs: http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-Build-1360/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12831095 - PreCommit-HIVE-Build

> Investigate IOException usage in Metrics APIs
> ---------------------------------------------
>
>                 Key: HIVE-14775
>                 URL: https://issues.apache.org/jira/browse/HIVE-14775
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive, HiveServer2, Metastore
>            Reporter: Barna Zsombor Klara
>            Assignee: Barna Zsombor Klara
>             Fix For: 2.2.0
>
>         Attachments: HIVE-14775.1.patch, HIVE-14775.patch
>
>
> A large number of metrics APIs seem to declare to throw IOExceptions needlessly. (incrementCounter,
decrementCounter etc.)
> This is not only misleading but it fills up the code with unnecessary catch blocks never
to be reached.
> We should investigate if these exceptions are thrown at all, and remove them if  it is
truly unused.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message