hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergio Peña (JIRA) <j...@apache.org>
Subject [jira] [Updated] (HIVE-14226) Invalid check on an ASTNode#toStringTree in CalcitePlanner
Date Wed, 28 Sep 2016 14:48:20 GMT

     [ https://issues.apache.org/jira/browse/HIVE-14226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sergio Peña updated HIVE-14226:
-------------------------------
    Target Version/s:   (was: 2.1.1)

> Invalid check on an ASTNode#toStringTree in CalcitePlanner
> ----------------------------------------------------------
>
>                 Key: HIVE-14226
>                 URL: https://issues.apache.org/jira/browse/HIVE-14226
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Barna Zsombor Klara
>            Assignee: Barna Zsombor Klara
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: HIVE-14226.patch
>
>
> The patch for HIVE-12590 has modified the string tree representation of an ASTNode, so
that everything except string literals are now lowercase.
> However CalcitePlanner#genSelectLogicalPlan is still checking the occurrence of an uppercase
TOK_FUNCTIONDI constant in the string tree.
> (Line 2997 in CalcitePlanner on master)
> I think this check will never evaluate to true, so we should either be using a lowercase
String, or remove the check if it is unnecessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message