Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7E157200B65 for ; Wed, 17 Aug 2016 22:29:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7CB3B160ABE; Wed, 17 Aug 2016 20:29:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C2F53160A6C for ; Wed, 17 Aug 2016 22:29:22 +0200 (CEST) Received: (qmail 78471 invoked by uid 500); 17 Aug 2016 20:29:22 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 78441 invoked by uid 99); 17 Aug 2016 20:29:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2016 20:29:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E1D432C0003 for ; Wed, 17 Aug 2016 20:29:21 +0000 (UTC) Date: Wed, 17 Aug 2016 20:29:21 +0000 (UTC) From: "Vaibhav Gumashta (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-14039) HiveServer2: Make the usage of server with JDBC thirft serde enabled, backward compatible for older clients MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 17 Aug 2016 20:29:23 -0000 [ https://issues.apache.org/jira/browse/HIVE-14039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425309#comment-15425309 ] Vaibhav Gumashta commented on HIVE-14039: ----------------------------------------- [~ziyangz] Thanks for the patch. Just went over the changes and here's my feedback: I think all the information that we need (config, version number, file format, whether the query is from HS2) to decide whether ThriftJDBCBinarySerde will get used is available to us during opening of a session on HS2 (HiveSessionImpl). How about we make this decision while opening a session in HS2 and simply set a boolean in SessionState. The boolean value can later be used to appropriately configure the logical plan in SemanticAnalyzer and physical plan in TaskCompiler. This will simplify code and also avoid the need for SematicAnalyzer & TaskCompiler to depend on service-rpc. > HiveServer2: Make the usage of server with JDBC thirft serde enabled, backward compatible for older clients > ----------------------------------------------------------------------------------------------------------- > > Key: HIVE-14039 > URL: https://issues.apache.org/jira/browse/HIVE-14039 > Project: Hive > Issue Type: Sub-task > Components: HiveServer2, JDBC > Affects Versions: 2.0.1 > Reporter: Vaibhav Gumashta > Assignee: Ziyang Zhao > Attachments: HIVE-14039.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)