hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Sankar Sivarama Subramaniyan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-14612) org.apache.hive.service.cli.operation.TestOperationLoggingLayout.testSwitchLogLayout failure
Date Thu, 25 Aug 2016 23:22:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438121#comment-15438121
] 

Hari Sankar Sivarama Subramaniyan edited comment on HIVE-14612 at 8/25/16 11:21 PM:
------------------------------------------------------------------------------------

[~prasanth_j] The reason we are changing the layout is because the console layout is defined
in hive-log4j2.properties via the following lines: 
{code}
rootLogger.appenderRef.console.ref = console

# console appender
appender.console.type = Console
appender.console.name = console
appender.console.target = SYSTEM_ERR
appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{ISO8601} %5p [%t] %c{2}: %m%n
{code}
And, the hardcoded patterns are used only if the layout for the console was set to null, which
in this case is not so.
https://github.com/apache/hive/blob/master/service/src/java/org/apache/hive/service/cli/operation/LogDivertAppender.java#L213

Also, I tested via the debugger (with and without HIVE-14405) to ensure that this is the case.



was (Author: hsubramaniyan):
[~prasanth_j] The reason we are changing the layout is because the console layout is defined
in hive-log4j2.properties via the following lines: 

rootLogger.appenderRef.console.ref = console

# console appender
appender.console.type = Console
appender.console.name = console
appender.console.target = SYSTEM_ERR
appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{ISO8601} %5p [%t] %c{2}: %m%n

And, the hardcoded patterns are used only if the layout for the console was set to null, which
in this case is not so.
https://github.com/apache/hive/blob/master/service/src/java/org/apache/hive/service/cli/operation/LogDivertAppender.java#L213

Also, I tested via the debugger (with and without HIVE-14405) to ensure that this is the case.


> org.apache.hive.service.cli.operation.TestOperationLoggingLayout.testSwitchLogLayout
failure
> --------------------------------------------------------------------------------------------
>
>                 Key: HIVE-14612
>                 URL: https://issues.apache.org/jira/browse/HIVE-14612
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-14612.1.patch
>
>
> Failing for some time



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message