hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14454) Vectorization: Varchar() -> String should not copy underlying buffers
Date Mon, 08 Aug 2016 18:22:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412207#comment-15412207
] 

Sergey Shelukhin commented on HIVE-14454:
-----------------------------------------

Nit: add comment explaining why it is ok to do?
Otherwise +1

> Vectorization: Varchar() -> String should not copy underlying buffers
> ---------------------------------------------------------------------
>
>                 Key: HIVE-14454
>                 URL: https://issues.apache.org/jira/browse/HIVE-14454
>             Project: Hive
>          Issue Type: Improvement
>          Components: Vectorization
>    Affects Versions: 2.2.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>         Attachments: HIVE-14454.1.patch
>
>
> The base byte[] array for a ByteColumnVector is immutable - all changes are made to a
scratch column.
> {code}
>   @Override
>   protected void func(BytesColumnVector outV, byte[][] vector, int[] start, int[] length,
int i) {
>     outV.setVal(i, vector[i], start[i], length[i]);
>   }
> {code}
> the setVal copies the byte[] array, losing dictionary encoding in the process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message