hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14409) Allow regex pattern in the output of qtest
Date Wed, 03 Aug 2016 07:28:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405494#comment-15405494
] 

Zoltan Haindrich commented on HIVE-14409:
-----------------------------------------

[~ajisakaa]
i think a micro dsl inside the q-files would be useful - for cases in which the application
output can't be reliably defined....

...but I think that hive's output for explain and such should be:

* stable(never change in repeated executions)
* and be as much as independent from the execution environment (like jdk version) as possible.

i'm afraid that making the test comparisions smarter may even hide bugs later on...
i think that burning a few more cycles of application time to produce more stable explain
outputs can even help the end user who is changing their application environment and looking
for any regresions after the changes have been made.
...when you look at just one line in an output you don't really know that the source of that
line was a list or a set; for a set it's perfectly fine to sort - but for an array it doesn't
really align with application internals.
i've worked toward stabilizing explain outputs lately in HIVE-14285, HIVE-14287, HIVE-14329
i know there are a few more affected...it seems to me that there are many explain output writing
methods here and there ;) ...i planning to somehow reduce the number of these and put more
pressure on the {{@Explain}} based output generator - which i think already can produce stable
outputs independently of jvm ; but if it's not - theres only one place where it has to be
fixed.

i know this is a "longer" path...what do you think about it?

> Allow regex pattern in the output of qtest
> ------------------------------------------
>
>                 Key: HIVE-14409
>                 URL: https://issues.apache.org/jira/browse/HIVE-14409
>             Project: Hive
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Akira Ajisaka
>
> We cannot guarantee the output from external libraries (ex. HashMap), so we need to make
the validation infrastructure to allow a sort within a single line.
> HIVE-13894, HIVE-13907, and HIVE-14088 are related.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message