Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Sun, 31 Jul 2016 09:22:20 +0000 (UTC)
From: "Lefty Leverenz (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12993762.1469911606000.180109.1469956940457@Atlassian.JIRA>
In-Reply-To: <JIRA.12993762.1469911606000@Atlassian.JIRA>
References: <JIRA.12993762.1469911606000@Atlassian.JIRA> <JIRA.12993762.1469911606288@arcas>
Subject: [jira] [Commented] (HIVE-14392) llap daemons should try using YARN
 local dirs, if available
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 31 Jul 2016 09:22:22 -0000


    [ https://issues.apache.org/jira/browse/HIVE-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401070#comment-15401070 ] 

Lefty Leverenz commented on HIVE-14392:
---------------------------------------

Review of parameter description in the first patch:

{code}
     LLAP_DAEMON_WORK_DIRS("hive.llap.daemon.work.dirs", "",
-      "Working directories for the daemon. Needs to be set for a secure cluster, since LLAP may\n" +
-      "not have access to the default YARN working directories. yarn.nodemanager.local-dirs is\n" +
-      "used if this is not set", "llap.daemon.work.dirs"),
+        "Working directories for the daemon. This should not be set if running as a Slider" +
+            " app on YARN. It must be setup when not running as a Slider application. If the value" +
+            " is set when running as a Slider app - the specified value will be used.",
+        "llap.daemon.work.dirs"),
{code}

1.  The first three lines of the new description need to end with newline (\n) just like the old description.  Otherwise it will appear as a single line in the generated file hive-default.xml.template.

2.  Indentation should be uniform, just like the old description, and no leading space is needed on the second and third lines if \n is used.

3.  "It must be setup" --> "It must be set" (or "It must be set up").

4.  Slider app / application / app:  although "app" is okay, you should spell out "application" the first time you use it, not the second time.  Spelling it out all three times would also be good.

5.  "as a Slider app - the specified value" --> "as a Slider app, the specified value" (or use two hyphens if you really want a dash there).

> llap daemons should try using YARN local dirs, if available
> -----------------------------------------------------------
>
>                 Key: HIVE-14392
>                 URL: https://issues.apache.org/jira/browse/HIVE-14392
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: HIVE-14392.01.patch
>
>
> LLAP required hive.llap.daemon.work.dirs to be specified. When running as a YARN app - this can use the local dirs for the container - removing the requirement to setup this parameter (for secure and non-secure clusters).


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)